Thread (13 messages) flat view 13 messages, 4 authors, 2008-01-15

Re: [FIB]: full_children & empty_children should be uint, not ushort

From: David Miller <davem@davemloft.net>
Date: 2008-01-14 06:32:05

From: Robert Olsson <redacted>
Date: Sun, 13 Jan 2008 23:02:11 +0100
Eric Dumazet writes:
 > Eric Dumazet a écrit :
 > > 4) full_children & empty_children being 'unsigned short',
 > >    we probably are limited to 2^15 elements, but I could not
 > >    find this limit enforced somewhere.

 > Two fixes are possible : Enlarge full_children & empty_children to 32bits, or 
 > force a limit in code to never exceed 2^15 children in a tnode. I chose the 
 > first solution since it can be done with 0 memory cost on 64bit arches.
 ...
 Thanks for spotting this. No we don't want put limits on the (root) node size.
 You see the comment in code is correct so unsigned short are some leftover from 
 old testing which could have hit us hard as the routing table slowly grows.
 ...
Signed-off-by: Robert Olsson <redacted>
Applied, thanks everyone.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help