Re: [PATCH 9/9] fix sparse warnings

From: Stephen Hemminger <redacted>
Date: Sat, 12 Jan 2008 13:09:46 -0800

On Sat, 12 Jan 2008 12:16:13 +0100
Eric Dumazet [off-list ref] wrote:

quoted

[FIB]: Reduce text size of net/ipv4/fib_trie.o

In struct tnode, we use two fields of 5 bits for 'pos' and 'bits'.
Switching to plain 'unsigned char' (8 bits) take the same space
because of compiler alignments, and reduce text size by 435 bytes
on i386.

On i386 :
$ size net/ipv4/fib_trie.o.before_patch net/ipv4/fib_trie.o
    text    data     bss     dec     hex filename
   13714       4      64   13782    35d6 net/ipv4/fib_trie.o.before
   13279       4      64   13347    3423 net/ipv4/fib_trie.o

Signed-off-by: Eric Dumazet <redacted>

I agree they should not have been bitfields in the first place.

Applied.