Thread (11 messages) 11 messages, 4 authors, 2007-12-31

Re: [PATCH] net: santize headers for iproute2

From: David Miller <davem@davemloft.net>
Date: 2007-12-30 03:22:15

From: Stephen Hemminger <redacted>
Date: Tue, 25 Dec 2007 17:13:10 -0800
Well changing netinet/tcp.h is just not a realistic proposition, it takes
too long to filter from glibc through distro's to be worth it.
But you have to, the ifdef mess you are suggesting is so much
worse.

Look at the reason you even have to do add the ifdefs, it's because
lo' and behold the congestion control defines have already propagated
properly into netinet/tcp.h

And this alone proves that your argument against putting this stuff in
the right place has no basis in reality.

Please just submit a patch to the appropriate place to get the
interfaces you need into netinet/tcp.h included instead of crapping
all over the kernel headers.

In the interum you can put a special header into the iproute2
distribution to handle this until it's sorted.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help