Re: [PATCH] net: santize headers for iproute2
From: David Miller <davem@davemloft.net>
Date: 2007-12-25 06:05:28
From: Stephen Hemminger <redacted> Date: Fri, 21 Dec 2007 09:43:36 -0800
iproute2 source uses headers that result from "make headers_install". The header files net/tcp_states.h and net/veth.h are both being used but are not processed. Signed-off-by: Stephen Hemminger <redacted>
The convention is to place user visible interfaces in header files under include/linux/ and purely kernel internal bits in header files under include/net/ Therefore exporting net/*.h headers is not right. net/veth.h only defines user visible interfaces, so it belongs under include/linux and added to include/linux/Kbuild, and I would happily take a patch implementing that. net/tcp_states.h is not movable to include/linux/ and thus to userspace, it defines things that are present already in existing userland header files. If you look, <netinet/tcp.h> defines these state values, as an enumeration. If you need the TCPF_* flag bit versions, sorry... you'll need to find some other way to get those into userspace.