Thread (17 messages) 17 messages, 3 authors, 2007-12-18

Re: [PATCH 4/4] udp: memory accounting in IPv4

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2007-12-04 00:27:16

On Mon, Dec 03, 2007 at 07:14:26PM -0500, Hideo AOKI wrote:
Let me try to use sk_forward_alloc at first, while percpu storage
is an interesting idea.
Actually I don't think sk_forward_alloc would work for UDP because
it runs lockless (unlike TCP which is run under a the socket lock).

So it's either going to be the atomic op or per-cpu counters.  For
me the atomic op isn't the issue, it's the SMP cache-line bouncing
that's more important so having something that did atomic ops on a
socket counter which then feeds into the global counter would solve
my concerns.

But let's wait and see what Dave has to say about this too.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help