Re: [PATCH 2/4] datagram: mem_scheudle functions
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2007-12-01 12:10:02
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2007-12-01 12:10:02
On Wed, Nov 28, 2007 at 01:52:59PM -0500, Hideo AOKI wrote:
+static inline int sk_wmem_schedule(struct sock *sk, int size)
+{
+ if (sk->sk_type == SOCK_STREAM)
+ return sk_stream_wmem_schedule(sk, size);
+ else if (sk->sk_type == SOCK_DGRAM)
+ return sk_datagram_wmem_schedule(sk, size);
+ else
+ return 1;
+}Why do we need this function? As far as I can see we always know whether it's a stream or datagram socket at compile time so doing a run-time test is pointless. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt