RE: [PATCH 3/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue
From: Waskiewicz Jr, Peter P <hidden>
Date: 2007-06-28 19:27:21
From: Waskiewicz Jr, Peter P <hidden>
Date: 2007-06-28 19:27:21
Waskiewicz Jr, Peter P wrote:quoted
quoted
[...] The only reasonable thing it can do is not care aboutmultiqueue andquoted
quoted
just dequeue as usual. In fact I think it should be an error to configure multiqueue on a non-root qdisc.Ack. This is a thought process that trips me up from timeto time...Iquoted
see child qdisc, and think that's the last qdisc to dequeueand sendquoted
to the device, not the first one to dequeue. So pleasedisregard myquoted
comments before; I totally agree with you. Great catchhere; I reallyquoted
like the prio_classify() cleanup.Thanks. This updated patch makes configuring a non-root qdisc for multiqueue an error.
The patch looks fine to me. Thanks Patrick. -PJ