Thread (60 messages) 60 messages, 9 authors, 2007-07-08

RE: [PATCH 3/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue

From: Waskiewicz Jr, Peter P <hidden>
Date: 2007-06-28 19:27:21

Waskiewicz Jr, Peter P wrote:
quoted
quoted
[...]
The only reasonable thing it can do is not care about 
multiqueue and 
quoted
quoted
just dequeue as usual. In fact I think it should be an error to 
configure multiqueue on a non-root qdisc.

Ack.  This is a thought process that trips me up from time 
to time...I 
quoted
see child qdisc, and think that's the last qdisc to dequeue 
and send 
quoted
to the device, not the first one to dequeue.  So please 
disregard my 
quoted
comments before; I totally agree with you.  Great catch 
here; I really 
quoted
like the prio_classify() cleanup.

Thanks. This updated patch makes configuring a non-root qdisc 
for multiqueue an error.
The patch looks fine to me.  Thanks Patrick.

-PJ
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help