RE: [PATCH 3/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue
From: Waskiewicz Jr, Peter P <hidden>
Date: 2007-06-28 16:43:10
From: Waskiewicz Jr, Peter P <hidden>
Date: 2007-06-28 16:43:10
PJ Waskiewicz wrote:quoted
+ static int __init prio_module_init(void) { - return register_qdisc(&prio_qdisc_ops); + int err; + err = register_qdisc(&prio_qdisc_ops); + if (!err) + err = register_qdisc(&rr_qdisc_ops); + return err; }Thats still broken. I'll fix this and some minor cleanness issues myself so you don't have to go through another resend.
Auke and I just looked at register_qdisc() and this code. Maybe we haven't had enough coffee yet, but register_qdisc() returns 0 on success. So if register_qdisc(&prio_qdisc_ops) succeeds, then rr_qdisc_ops gets registered. I'm curious what is broken with this. Thanks Patrick -PJ Waskiewicz