Thread (37 messages) 37 messages, 4 authors, 2007-07-03

Re: [PATCH] [TCP]: Fix GSO ignorance of pkts_acked arg (cong.cntrl modules)

From: Ilpo Järvinen <hidden>
Date: 2007-06-01 11:22:57

On Thu, 31 May 2007, David Miller wrote:
From: "Ilpo_Järvinen" <redacted>
Date: Wed, 30 May 2007 12:10:06 +0300 (EEST)
quoted
[PATCH] [TCP]: Fix GSO ignorance of pkts_acked arg (cong.cntrl modules)

The code used to ignore GSO completely, passing either way too
small or zero pkts_acked when GSO skb or part of it got ACKed.
In addition, there is no need to calculate the value in the loop
but simple arithmetics after the loop is sufficient. There is
no need to handle SYN case specially because congestion control
modules are not yet initialized when FLAG_SYN_ACKED is set.

Signed-off-by: Ilpo Järvinen <redacted>
Patch applied, thanks a lot!
...It's good to be on the alert with this one because it might uncover
some hidden bugs from congestion control module code (it changes some 
behavior so radically), which obviously will have to be then fixed
too...


-- 
 i.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help