Re: [PATCH 3/9] [TCP]: Tighten tcp_sock's belt, drop left_out
From: David Miller <davem@davemloft.net>
Date: 2007-05-31 08:42:27
From: David Miller <davem@davemloft.net>
Date: 2007-05-31 08:42:27
From: "Ilpo_Järvinen" <redacted> Date: Sat, 26 May 2007 11:35:56 +0300
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <redacted> It is easily calculable when needed and user are not that many after all. Signed-off-by: Ilpo Järvinen <redacted>
This looks good, but are you absolutely sure we never used a stale value of tp->left_out on purpose? I tried to audit this but there are so many cases :-) What I mean here is, was there a case where we updated sacked_out or lost_out, but then used left_out before it was updated, and we were doing this on purpose?