Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa

On Feb 8, 2007, at 8:35 AM, Timur Tabi wrote:

That's what the original code did, kinda.  It called virt_to_phys() if
it is main memory, and it called immrbar_virt_to_phys() if it is  
MURAM.
  immrbar_virt_to_phys() did pointer math to extract the physical  
address.

You've got to be kidding.  You created yet another function
to determine the physical address from a virtual one! LOL!
Plus, you need logic in the code to first determine which
one to call?  Everyone is OK with this?


	-- Dan