Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa

On Feb 7, 2007, at 3:34 AM, Li Yang-r58472 wrote:

quoted

On Feb 6, 2007, at 5:31 AM, Li Yang wrote:

quoted

Get rid of private immrbar_virt_to_phys() routine and
use generic iopa().

Nack. iopa() isn't that generic, shouldn't we really be using the dma
mapping API here?

Do you mean the dma_map_single()?  dma_map_single can map memory space
correctly, but I don't think it can handle ioremap-ed space.

What are you mapping?  It looks like buffer descriptor rings.  Are  
they being kept in QE sram?  If so that I think you can treat it as  
memory.  (I believe the SRAM behaves like memory, is cache-coherent,  
etc).

- k