Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa

On Feb 7, 2007, at 10:43 AM, Timur Tabi wrote:

Kumar Gala wrote:

quoted

On Feb 6, 2007, at 5:31 AM, Li Yang wrote:

quoted

Get rid of private immrbar_virt_to_phys() routine and
use generic iopa().

Nack. iopa() isn't that generic, shouldn't we really be using the  
dma mapping API here?

I'm having a hard time understanding what's wrong with iopa().  Is  
it because it's a 32-bit only function?  The memory has already  
been mapped with ioremap(), so why would we want to map it again?

If its been mapped with ioremap() you know the physical address  
already so why do you need iopa().  The problem I have is iopa() is  
ppc specific and I can envision a day when someone wants to run Linux  
on a StarCore + QE, so having the drivers using ppc specific APIs is  
bad.

- k