On Wed, Feb 28, 2007 at 10:16:05AM +0100, Johannes Berg wrote:

Hi,

quoted

	Patch for 2.6.20 is attached.

... and in the meantime netdevices aren't class_device any more :) IOW,
your patch isn't going to work any more.

	That's why I always specify the kernel version. I'll look into
that, I'm sure it's not the end of the world ;-)

Also, I think wireless could benefit from this as well.

	In which sense ? Wireless interface are regular netdevices.

quoted

        The kobject framework is well designed, so adding these
features is trivial change and won't run the risk of breaking anything
(famous last words). Obviously, hotplug apps are free to ignore those
additional features.

Why not just add this to base kobject_rename instead? That way,
userspace is notified for all renames in sysfs.
The patch then collapses down to the change in net's sysfs code to add
the ifindex to the environment, and another change in kobject to invoke
a new event when a name changes and show the old name.

	I'm just trying to follow the established pattern. Both
class_device_add() and class_device_del() are generating the
event. Also, I'm not sure if other subsystem would benefit from it, I
don't want to generate too many useless events.

johannes

	Thanks !

	Jean