Re: [PATCH 2.6.20] kobject net ifindex + rename

On Wed, Feb 28, 2007 at 07:36:17AM -0800, Greg KH wrote:

On Tue, Feb 27, 2007 at 05:27:41PM -0800, Jean Tourrilhes wrote:

quoted

diff -u -p linux/drivers/base/class.j1.c linux/drivers/base/class.c

--- linux/drivers/base/class.j1.c	2007-02-26 18:38:10.000000000 -0800
+++ linux/drivers/base/class.c	2007-02-27 15:52:37.000000000 -0800

@@ -841,6 +841,8 @@ int class_device_rename(struct class_dev

This function is not in the 2.6.21-rc2 kernel, so you might want to
rework this patch a bit :)

	It was a trial balloon to gather feedback. I will do.

Also, it's userspace that causes the rename to happen, so it knows it
did it, why should the kernel have to emit a message to tell userspace
again what just happened?

	Username is not one big program, but a collection of program,
and one program does not know what another program do.
	In particular, udev does not know when people are using
iproute2 to rename interface and loose its marbles. We don't really
want to ban iproute2 or udev ;-)

thanks,

greg k-h

	Have fun...

	Jean