Re: [RFT] bridge: eliminate port_check workqueue
From: Jarek Poplawski <hidden>
Date: 2007-02-22 08:42:44
Also in:
lkml
On Wed, Feb 21, 2007 at 10:55:55AM -0800, Stephen Hemminger wrote:
This is what I was suggesting by getting rid of the work queue completely.
...
quoted hunk ↗ jump to hunk
--- bridge.orig/net/bridge/br_if.c 2007-02-21 10:22:46.000000000 -0800 +++ bridge/net/bridge/br_if.c 2007-02-21 10:53:25.000000000 -0800@@ -77,26 +77,15 @@ * Called from work queue to allow for calling functions that * might sleep (such as speed check), and to debounce. */
What about this comment?
-static void port_carrier_check(struct work_struct *work) +void br_port_carrier_check(struct net_bridge_port *p)
Of course my opinion shouldn't matter here, but it looks like withdrawing (or giving up) to the older way. So I'm not excited, but I trust there is a reason for this. Cheers, Jarek P.