[PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check() · Oleg Nesterov <hidden> · 2007-02-20
Re: [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check() · Stephen Hemminger <hidden> · 2007-02-21
Re: [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check() · Jarek Poplawski <hidden> · 2007-02-21
Re: [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check() · Jarek Poplawski <hidden> · 2007-02-21
Re: [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check() · Oleg Nesterov <hidden> · 2007-02-21
[RFT] bridge: eliminate port_check workqueue · Stephen Hemminger <hidden> · 2007-02-21
Re: [RFT] bridge: eliminate port_check workqueue · Oleg Nesterov <hidden> · 2007-02-21
Re: [RFT] bridge: eliminate port_check workqueue · Stephen Hemminger <hidden> · 2007-02-21
Re: [RFT] bridge: eliminate port_check workqueue · Oleg Nesterov <hidden> · 2007-02-21
Re: [RFT] bridge: eliminate port_check workqueue · Jarek Poplawski <hidden> · 2007-02-22
Re: [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check() · Oleg Nesterov <hidden> · 2007-02-21

Re: [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check()

From: Oleg Nesterov <hidden>
Date: 2007-02-21 14:23:46
Also in: lkml

On 02/21, Jarek Poplawski wrote:

quoted

On Wed, 21 Feb 2007 01:19:41 +0300
Oleg Nesterov [off-list ref] wrote:

quoted

+	p = container_of(work, struct net_bridge_port, carrier_check.work);
 
 	rtnl_lock();
-	p = dev->br_port;
-	if (!p)
-		goto done;
 	br = p->br;

It doesn't matter very much but I think this would look
better after the first if check.

OK. I can re-send if this patch is otherwise correct.

Oleg.