Re: [RFT] bridge: eliminate port_check workqueue
From: Stephen Hemminger <hidden>
Date: 2007-02-21 21:20:49
Also in:
lkml
On Wed, 21 Feb 2007 23:09:16 +0300 Oleg Nesterov [off-list ref] wrote:
On 02/21, Stephen Hemminger wrote:quoted
This is what I was suggesting by getting rid of the work queue completely.Can't comment this patch, but if we can get rid of the work_struct - good!quoted
-static void port_carrier_check(struct work_struct *work) +void br_port_carrier_check(struct net_bridge_port *p) { - struct net_bridge_port *p; - struct net_device *dev; - struct net_bridge *br; - - dev = container_of(work, struct net_bridge_port, - carrier_check.work)->dev; - work_release(work);May I ask you to redo this patch on top of [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR http://marc.theaimsgroup.com/?l=linux-kernel&m=117183517612775 ? We are removing the _NAR stuff, it would be nice to do this in a separate patch. Thanks! Oleg.
I would rather put it in a bugfix patchset for 2.6.21 and 2.6.20-stable -- Stephen Hemminger [off-list ref]