Thread (128 messages) 128 messages, 16 authors, 2006-08-25

Re: [RFC][PATCH 8/9] 3c59x driver conversion

From: Peter Zijlstra <hidden>
Date: 2006-08-09 07:04:10
Also in: linux-mm, lkml

On Wed, 2006-08-09 at 02:30 -0400, Jeff Garzik wrote:
David Miller wrote:
quoted
From: Daniel Phillips <redacted>
Date: Tue, 08 Aug 2006 22:51:20 -0700
quoted
Elaborate please.  Do you think that all drivers should be updated to
fix the broken blockdev semantics, making NETIF_F_MEMALLOC redundant?
If so, I trust you will help audit for it?
I think he's saying that he doesn't think your code is yet a
reasonable way to solve the problem, and therefore doesn't belong
upstream.
Pretty much.  It is completely non-sensical to add NETIF_F_MEMALLOC, 
when it should be blindingly obvious that every net driver will be 
allocating memory, and every net driver could potentially be used with 
NBD and similar situations.
Sure, but until every single driver is converted I'd like to warn people
about the fact that their setups is not up to expectations. Iff all
drivers are converted I'll be the forst to submit a patch that removes
the feature flag.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help