Re: [PATCH 2/4] myri10ge - Driver header files

Randy.Dunlap wrote:

quoted

[PATCH 2/4] myri10ge - Driver header files

 myri10ge_mcp.h            |  205 ++++++++++++++++++++++++++++++++++++++++++++++
 myri10ge_mcp_gen_header.h |   58 +++++++++++++
    

Please use "diffstat -p 1 -w 70" is documented in
Documentation/SubmittingPatches.
  

Ok, will do.

quoted

+/* 16 Bytes */
    

What is 16 bytes here?
  

quoted

+struct mcp_slot {
+	u16 checksum;
+	u16 length;
+};
    

Looks like I have problems to compute the size of this type.

Thanks,
Brice