On Sun, Mar 26, 2006 at 09:05:18AM -0500, jamal wrote:

On Sat, 2006-25-03 at 23:52 +0530, Balbir Singh wrote:

quoted

No, we cannot have both passed. If we pass both a PID and a TGID and
then the code returns just the stats for the PID.

ok, that clears it then; i think you are ready to go.

Cool! Thanks for all your help and review.

quoted

quoted

Also in regards to the nesting, isnt there a need for nla_nest_cancel in
case of failures to add TLVs?

I thought about it, but when I looked at the code of genlmsg_cancel()
and nla_nest_cancel().  It seemed that genlmsg_cancel() should
suffice.

If your policy is to never send a message if anything fails, then you
are fine.

What would be really useful now that you understand this, is if you can
help extending/cleaning the document i sent you. Or send me a table of
contents of how it would have flowed better for you.

I will start looking at the document and see what changes can be made.
I will try and update the document from a genetlink programmers perspective
i.e. things to know, avoid, etc.

cheers,
jamal

Thanks,
Balbir