On Fri, Mar 24, 2006 at 09:11:58AM -0500, jamal wrote:

On Fri, 2006-24-03 at 07:02 +0530, Balbir Singh wrote:

quoted

On Thu, Mar 23, 2006 at 09:04:46AM -0500, jamal wrote:

quoted

3. nlmsg_new() now allocates for 2*u32 + sizeof(taskstats)

Not the right size; the u32 covers the V part of TLV. The T = 16 bits
and L = 16 bits. And if you nest TLVs, then it gets more interesting.

Look at using proper macros instead of hard coding like you did.
grep for something like RTA_SPACE and perhaps send a patch to make it
generic for netlink.h

cheers,
jamal

My bad,  but I was wondering why my test case did not segfault until
I saw the implementation of nlmsg_new :-)

I will fix this and use nla_total_size() to calculate the correct sizes
including padding and TLV.

Thanks again,
Balbir