On Mon, 14 Mar 2005 15:17:26 -0800
Stephen Hemminger [off-list ref] wrote:

+/* Hook for advanced congestion control */
+	struct tcp_ca_type *ca_proto;
+#define TCP_CA_PRIV_SIZE	48
+	u8	         *ca_priv[TCP_CA_PRIV_SIZE];

An array of 48 pointers to "u8" eh? :-)

It happens to work, but you're using too much
space (specifically: 48 * sizeof(u8 *)) as a side effect.

Otherwise, the only comment I have is that we lose the tcp_diag
info.  Maybe create a "tcpdiag_put" method in there so we can
retain that.

I'm also not so religious anymore about retaining the existing
sysctl functionality to enable/disable ca algs.