Thread (11 messages) 11 messages, 4 authors, 2005-03-10

Re: pppoe and receive checksum offload

From: <hidden>
Date: 2005-03-01 00:01:33

On Mon, 28 Feb 2005 09:12:52 -0800
Stephen Hemminger [off-list ref] wrote:
quoted
The original sk98lin attempted to receive hardware checksumming
but never actually turned it on.
Because there is a bug in the chip wherein checksums can be
miscalculated.  I forget the details, but I do remember that
you can't enable checksumming safely because of this.

In drivers/net/sk98lin/skcsum.c it mentions this:

 * Note:
 *      There is a bug in the GENESIS ASIC which may lead to wrong
checksums.

I know this comment is above the send checksum routine, but I
am pretty sure the bug applies to both directions.
The driver covers two types of chips (Genesis and Yukon). The new
driver only allows receive checksum on Yukon chipset. Almost all
current hardware uses Yukon and it has been pretty well tested.
The issues the sk98lin had were sloppy coding and handling of
unsigned arithmetic.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help