Thread (11 messages) 11 messages, 4 authors, 2005-03-10

Re: pppoe and receive checksum offload

From: Alexey Kuznetsov <hidden>
Date: 2005-02-28 14:04:01

Hello!
Actually ip_gre is probably right.  It seems that CHECKSUM_UNNECESSARY
should not be set for PPPOE/GRE packets at all.  So it would be a bug in
the sk* driver.

Alexey/Dave, is this interpretation of ip_summed correct?
What's about CHECKSUM_UNNECESSARY, yes, it is set only for TCP/UDP packets,
when device verifies the checksum itself. It is not the case for
PPOE frames. CHECKSUM_HW is more flxible, ipip/gre tunnels use this adjusting
skb->csum by checksum of stripped headers.

ppp_input() could do the same thing. It does not, hence suggested patch
is corrrect minimal solution.

Alexey
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help