Thread (11 messages) 11 messages, 4 authors, 2005-03-10

Re: pppoe and receive checksum offload

From: Alexey Kuznetsov <hidden>
Date: 2005-02-28 09:21:30

Hello!
Changing or expanding the link level headers should only mess
up the hw checksum if you are using CHECKSUM_HW, is that what
your skge driver is using?
Well, even if this driver uses CHECKSUM_UNNECESSARY, the bug is still
apparently present for another devices which use CHECKSUM_HW.

Actually, the bug is in ppp_input(). It is responsible for setting correct
ip_summed before doing netif_rx(). It could even optimize subtracting
checksum of stripped ppp header from ip_summed (f.e. ipgre_rcv() do this)

But suggested fix is still correct. Unless there are another users of
ppp_input() with the same problem.

Alexey
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help