Re: [PATCH] Improve behaviour of Netlink Sockets

On Wed, 29 Sep 2004 13:27:24 +1000
Herbert Xu [off-list ref] wrote:

On Tue, Sep 28, 2004 at 10:52:05PM -0400, jamal wrote:

quoted

quoted

You're right.  rtmsg_info() is using GOODISZE unnecessarily.  I'll
write up a patch.

But why? ;->

So that the alloc_skb() is slightly less likely to fail.  The dumpers
gain a lot by using GOODSIZE since they can fill it up.  As rtmsg_info
has no chance of getting anywhere near GOODSIZE we should provide a
more accruate estimate.

It also means that with netlink_trim() you'll save a realloc/copy.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Dave, you can stop reading now :)

Hehe, ok.  Patch applied :-)

Thanks.