Re: [PATCH] Improve behaviour of Netlink Sockets

On Wed, 29 Sep 2004 09:19:06 +1000
Herbert Xu [off-list ref] wrote:

quoted

===== net/netlink/af_netlink.c 1.58 vs edited =====

--- 1.58/net/netlink/af_netlink.c	Sat Sep 25 17:43:43 2004
+++ edited/net/netlink/af_netlink.c	Tue Sep 28 22:23:44 2004

@@ -475,7 +475,7 @@
 	if (nlk->handler)
 		return 0;
 #endif
-	if (atomic_read(&sk->sk_rmem_alloc) > sk->sk_rcvbuf ||
+	if (atomic_read(&sk->sk_rmem_alloc) + skb->len > sk->sk_rcvbuf ||

I don't see the point of this patch.  All it does is make the overrun
happen one packet earlier.

That's my sentiment as well.