Thread (13 messages) 13 messages, 4 authors, 2003-09-15

Re: [PATCH 1/4] Net device error logging, revised

From: Greg KH <hidden>
Date: 2003-08-26 19:04:51
Also in: lkml

On Mon, Aug 25, 2003 at 02:31:19PM -0700, Jim Keniston wrote:
+int __netdev_printk(const char *sevlevel, const struct net_device *netdev,
+	int msglevel, const char *format, ...)
+{
+	if (!netdev || !format) {
+		return -EINVAL;
+	}
+	if (msglevel == NETIF_MSG_ALL || (netdev->msg_enable & msglevel)) {
+		char msg[512];
512 bytes on the stack?  Any way to prevent this from happening?  With
the push to make the stack even smaller in 2.7, people will not like
this.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help