Re: [PATCH v2 2/6] parisc: Drop own implementations for ptep_get() and ptep_test_and_clear_young()

On Tue, Aug 04, 2026 at 03:00:43PM +0200, Helge Deller wrote:

On 8/4/26 14:42, Lorenzo Stoakes (ARM) wrote:

quoted

On Tue, Aug 04, 2026 at 01:34:41PM +0100, Pedro Falcato wrote:

quoted

On Tue, Aug 04, 2026 at 12:11:08PM +0100, Lorenzo Stoakes (ARM) wrote:

quoted

On Mon, Aug 03, 2026 at 05:43:56PM +0100, Pedro Falcato wrote:

quoted

From: Helge Deller <deller@gmx.de>

Switch to the generic implementations, which are identical.

You sure do like succinct commit messages :)

I didn't even write this one! See the From: :))

Lol well then feedback addressed to Helge ;)

Noted :-)

quoted

quoted

quoted

Maybe worth saying by dropping the __HAVE_ARCH_PTEP_TEST_AND_CLEAR_YOUNG and
ptep_get defines you get the generic versions from include/pgtable.h which are
functionally identical.

Isn't that basically the same as:
"Switch to the generic implementations, which are identical."
;-)

I am being _exceedingly_, possibly outrageously pedantic here :>)

quoted

quoted

I can touch it up though, if you insist.

Yeah, I'm being pedantic here it's not vital to have this change :) but be nice
if you could, I'm sure Helge probably wouldn't mind too much? :)

Yes, I'm fine with any cleanup/rephrasing of the commit message.

Thanks :)

Thanks!
Helge

quoted

quoted

quoted

(Being pedantic, they're not quite strictly identical as the
ptep_test_and_clear_young() generic function does some weird unnecessary
indirection with a local variable and the single {} is dropped etc.)

--
Cheers, Lorenzo