Re: [PATCH v2 2/6] parisc: Drop own implementations for ptep_get() and ptep_test_and_clear_young()

On Tue, Aug 04, 2026 at 12:11:08PM +0100, Lorenzo Stoakes (ARM) wrote:

On Mon, Aug 03, 2026 at 05:43:56PM +0100, Pedro Falcato wrote:

quoted

From: Helge Deller <deller@gmx.de>

Switch to the generic implementations, which are identical.

You sure do like succinct commit messages :)

I didn't even write this one! See the From: :))

Maybe worth saying by dropping the __HAVE_ARCH_PTEP_TEST_AND_CLEAR_YOUNG and
ptep_get defines you get the generic versions from include/pgtable.h which are
functionally identical.

I can touch it up though, if you insist.

(Being pedantic, they're not quite strictly identical as the
ptep_test_and_clear_young() generic function does some weird unnecessary
indirection with a local variable and the single {} is dropped etc.)

quoted

Suggested-by: Usama Arif <usama.arif@linux.dev>
Suggested-by: John David Anglin <redacted>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Pedro Falcato <pfalcato@suse.de>

Nits above notwithstanding, LGTM so:

Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>

Thanks!

-- 
Pedro