Re: [PATCH v18 11/13] PCI: Cache PCI DSN into pci_dev->dsn during probe
From: Lukas Wunner <lukas@wunner.de>
Date: 2026-07-21 08:37:48
Also in:
linux-acpi, linux-cxl, linux-doc, linux-pci, lkml
On Mon, Jul 20, 2026 at 10:48:06AM -0500, Bowman, Terry wrote:
quoted hunk ↗ jump to hunk
+++ b/drivers/pci/hotplug/pciehp.h@@ -90,7 +90,6 @@ extern int pciehp_poll_time; */ struct controller { struct pcie_device *pcie; - u64 dsn;
Please drop the kernel-doc for this struct member as well.
quoted hunk ↗ jump to hunk
+++ b/drivers/pci/hotplug/pciehp_hpc.c@@ -1086,8 +1086,6 @@ struct controller *pcie_init(struct pcie_device *dev) } pdev = pci_get_slot(subordinate, PCI_DEVFN(0, 0)); - if (pdev) - ctrl->dsn = pci_get_dsn(pdev); pci_dev_put(pdev);
Please drop the pci_get_slot() + pci_dev_put() as well, they're obviously superfluous now.
quoted hunk ↗ jump to hunk
+++ b/drivers/pci/hotplug/pciehp_pci.c@@ -73,7 +73,6 @@ int pciehp_configure_device(struct controller *ctrl) down_read_nested(&ctrl->reset_lock, ctrl->depth); dev = pci_get_slot(parent, PCI_DEVFN(0, 0)); - ctrl->dsn = pci_get_dsn(dev); pci_dev_put(dev);
Same here. Thanks, Lukas