Re: [PATCH v2 04/18] cpufreq: brcmstb-avs-cpufreq: Use __free(put_cpufreq_policy) for policy reference

From
Zihuan Zhang <hidden>
Date
2025-08-29 06:16:41
Also in
dri-devel, imx, intel-gfx, kvm, linux-acpi, linux-mediatek, linux-omap, linux-pm, linux-samsung-soc, linux-tegra, lkml
Reply to
Viresh Kumar, 2025-08-29
在 2025/8/29 13:59, Viresh Kumar 写道:
On 27-08-25, 10:31, Zihuan Zhang wrote:
quoted
Replace the manual cpufreq_cpu_put() with __free(put_cpufreq_policy)
annotation for policy references. This reduces the risk of reference
counting mistakes and aligns the code with the latest kernel style.

No functional change intended.

Signed-off-by: Zihuan Zhang <redacted>
---
  drivers/cpufreq/brcmstb-avs-cpufreq.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
Applied. Thanks.
Thanks for applying the patch!

I’ve been thinking further — instead of using __free directly, maybe we could introduce a small macro wrapper around it to make the release scope more controllable and consistent.

Link: https://lore.kernel.org/all/6174bcc8-30f5-479b-bac6-f42eb1232b4d@kylinos.cn/ (local)

Do you think this would be a better approach, or should we just stick with the current use of __free?



Thread (39 messages) 39 messages, 6 authors, last reply 2025-08-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help