[PATCH v2 03/18] ACPI: processor: thermal: Use __free(put_cpufreq_policy) for policy reference
From: Zihuan Zhang <hidden>
Date: 2025-08-27 02:33:20
Also in:
dri-devel, imx, intel-gfx, kvm, linux-acpi, linux-mediatek, linux-omap, linux-pm, linux-samsung-soc, linux-tegra, lkml
Subsystem:
acpi, acpi thermal driver, the rest · Maintainers:
"Rafael J. Wysocki", Rafael J. Wysocki, Linus Torvalds
Replace the manual cpufreq_cpu_put() with __free(put_cpufreq_policy) annotation for policy references. This reduces the risk of reference counting mistakes and aligns the code with the latest kernel style. No functional change intended. Signed-off-by: Zihuan Zhang <redacted> --- drivers/acpi/processor_thermal.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/acpi/processor_thermal.c b/drivers/acpi/processor_thermal.c
index 1219adb11ab9..f99ed0812934 100644
--- a/drivers/acpi/processor_thermal.c
+++ b/drivers/acpi/processor_thermal.c@@ -64,17 +64,13 @@ static int phys_package_first_cpu(int cpu) static int cpu_has_cpufreq(unsigned int cpu) { - struct cpufreq_policy *policy; + struct cpufreq_policy *policy __free(put_cpufreq_policy); if (!acpi_processor_cpufreq_init) return 0; policy = cpufreq_cpu_get(cpu); - if (policy) { - cpufreq_cpu_put(policy); - return 1; - } - return 0; + return !!policy; } static int cpufreq_get_max_state(unsigned int cpu)
@@ -95,7 +91,7 @@ static int cpufreq_get_cur_state(unsigned int cpu) static int cpufreq_set_cur_state(unsigned int cpu, int state) { - struct cpufreq_policy *policy; + struct cpufreq_policy *policy __free(put_cpufreq_policy); struct acpi_processor *pr; unsigned long max_freq; int i, ret;
@@ -127,8 +123,6 @@ static int cpufreq_set_cur_state(unsigned int cpu, int state) max_freq = (policy->cpuinfo.max_freq * (100 - reduction_step(i) * cpufreq_thermal_reduction_pctg)) / 100; - cpufreq_cpu_put(policy); - ret = freq_qos_update_request(&pr->thermal_req, max_freq); if (ret < 0) { pr_warn("Failed to update thermal freq constraint: CPU%d (%d)\n",
--
2.25.1