On Wed, Feb 12, 2025 at 01:33:14PM -0600, Rob Herring wrote:

On Fri, Feb 07, 2025 at 10:30:20PM +0100, J. Neuschäfer wrote:

quoted

Convert the Freescale security engine (crypto accelerator) binding from
text form to YAML. The list of compatible strings reflects what was
previously described in prose; not all combinations occur in existing
devicetrees.

Signed-off-by: J. Neuschäfer <redacted>
---

V2:
- several improvements suggested by Rob Herring:
  - remove unnecessary multiline markers
  - constrain fsl,num-channels to enum: [1,4]
  - constrain fsl,channel-fifo-len to plausible limits
  - constrain fsl,exec-units-mask to maximum=0xfff
- trim subject line (remove "binding")
---
 .../devicetree/bindings/crypto/fsl,sec2.0.yaml     | 142 +++++++++++++++++++++
 .../devicetree/bindings/crypto/fsl-sec2.txt        |  65 ----------
 2 files changed, 142 insertions(+), 65 deletions(-)

[...]

quoted

+title: Freescale SoC SEC Security Engines versions 1.x-2.x-3.x
+
+maintainers:
+  - J. Neuschäfer <j.ne@posteo.net.

missing >

Good catch, will fix.

quoted

+  fsl,descriptor-types-mask:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: |
+      The bitmask representing what descriptors are available. Descriptor type
+      information should be encoded following the SEC's Descriptor Header Dword
+      DESC_TYPE field documentation, i.e. as follows:
+
+        bit 0  = set if SEC supports the aesu_ctr_nonsnoop desc. type
+        bit 1  = set if SEC supports the ipsec_esp descriptor type
+        bit 2  = set if SEC supports the common_nonsnoop desc. type
+        bit 3  = set if SEC supports the 802.11i AES ccmp desc. type
+        bit 4  = set if SEC supports the hmac_snoop_no_afeu desc. type
+        bit 5  = set if SEC supports the srtp descriptor type
+        bit 6  = set if SEC supports the non_hmac_snoop_no_afeu desc.type
+        bit 7  = set if SEC supports the pkeu_assemble descriptor type
+        bit 8  = set if SEC supports the aesu_key_expand_output desc.type
+        bit 9  = set if SEC supports the pkeu_ptmul descriptor type
+        bit 10 = set if SEC supports the common_nonsnoop_afeu desc. type
+        bit 11 = set if SEC supports the pkeu_ptadd_dbl descriptor type

Why 3 variations of 'descriptor type'?

The reasons have been lost in time, I suppose. I'll normalize the spelling.


Thanks,
J. Neuschäfer