Re: [PATCH v6 24/26] powerpc/pseries: Implement secvars for dynamic secure boot

From
Andrew Donnellan <hidden>
Date
2023-02-13 07:07:00
Also in
linux-integrity, lkml
Reply to
Stefan Berger, 2023-02-10
On Fri, 2023-02-10 at 16:23 -0500, Stefan Berger wrote:
quoted
+       memcpy(&flags, data, sizeof(flags));
conversion from bytestream to integer: I think in this case it would
be better to use

flags = cpu_to_be64p((__u64*)data);

so that the flags always in hypervisor/big endian format
Thanks for catching this - it turns out we weren't properly testing the
one flag that exists (append vs replace) in our test script, so I
didn't notice this.

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@linux.ibm.com   IBM Australia Limited
Thread (42 messages) 42 messages, 4 authors, last reply 2023-02-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help