Thread (42 messages) 42 messages, 4 authors, 2023-02-15

Re: [PATCH v6 24/26] powerpc/pseries: Implement secvars for dynamic secure boot

flat view

From: Andrew Donnellan <hidden>
Date: 2023-02-12 13:33:47
Also in: linux-integrity, lkml

On Fri, 2023-02-10 at 16:28 -0500, Stefan Berger wrote:
quoted
quoted
+err:
+    kfree(var.data);
remove the kfree()
Actually don't remove it but it should probably be

if (var.data != &version)
     kfree(var.data);
Argh, thanks for catching this.

I don't think the condition is needed - we can assume the var.data is
unmodified.

mpe, are you able to fix this up in merge?

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@linux.ibm.com   IBM Australia Limited
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help