Re: [PATCH v6 24/26] powerpc/pseries: Implement secvars for dynamic secure boot

From
Michael Ellerman <hidden>
Date
2023-02-13 05:27:18
Also in
linux-integrity, lkml
Reply to
Andrew Donnellan, 2023-02-12
Andrew Donnellan [off-list ref] writes:
On Fri, 2023-02-10 at 16:28 -0500, Stefan Berger wrote:
quoted
quoted
quoted
+err:
+    kfree(var.data);
remove the kfree()
Actually don't remove it but it should probably be

if (var.data != &version)
     kfree(var.data);
Argh, thanks for catching this.

I don't think the condition is needed - we can assume the var.data is
unmodified.

mpe, are you able to fix this up in merge?
Yeah, can you reply here with the delta you want applied.

cheers
Thread (42 messages) 42 messages, 4 authors, last reply 2023-02-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help