Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions
From: Suren Baghdasaryan <surenb@google.com>
Date: 2023-01-26 16:26:50
Also in:
alsa-devel, amd-gfx, bpf, dmaengine, dri-devel, intel-gfx, kexec, kvm, linux-acpi, linux-arch, linux-arm-msm, linux-crypto, linux-ext4, linux-fbdev, linux-fsdevel, linux-media, linux-mediatek, linux-mm, linux-perf-users, linux-rdma, linux-s390, linux-samsung-soc, linux-scsi, linux-staging, linux-tegra, linux-um, linux-usb, linux-xfs, lkml, loongarch, netdev, nvdimm, selinux, sparclinux, target-devel, xen-devel
On Thu, Jan 26, 2023 at 7:09 AM Matthew Wilcox [off-list ref] wrote:
On Thu, Jan 26, 2023 at 04:50:59PM +0200, Mike Rapoport wrote:quoted
On Thu, Jan 26, 2023 at 11:17:09AM +0200, Mike Rapoport wrote:quoted
On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote:quoted
+/* Use when VMA is not part of the VMA tree and needs no locking */ +static inline void init_vm_flags(struct vm_area_struct *vma, + unsigned long flags)I'd suggest to make it vm_flags_init() etc.Thinking more about it, it will be even clearer to name these vma_flags_xyz()Perhaps vma_VERB_flags()? vma_init_flags() vma_reset_flags() vma_set_flags() vma_clear_flags() vma_mod_flags()
Due to excessive email bouncing I posted the v3 of this patchset using the original per-VMA patchset's distribution list. That might have dropped Mike from the list. Sorry about that Mike, I'll add you to my usual list of suspects :) The v3 is here: https://lore.kernel.org/all/20230125233554.153109-1-surenb@google.com/ (local) and Andrew did suggest the same renames, so I'll be posting v4 with those changes later today. Thanks for the feedback!