Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions

[PATCH v2 0/6] introduce vm_flags modifier functions · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
[PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls · Michal Hocko <mhocko@suse.com> · 2023-01-25
Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls · Mike Rapoport <rppt@kernel.org> · 2023-01-26
Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls · Sebastian Reichel <hidden> · 2023-01-26
[PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Michal Hocko <mhocko@suse.com> · 2023-01-25
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Peter Zijlstra <peterz@infradead.org> · 2023-01-25
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Matthew Wilcox <willy@infradead.org> · 2023-01-25
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Matthew Wilcox <willy@infradead.org> · 2023-01-25
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Mike Rapoport <rppt@kernel.org> · 2023-01-26
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Mike Rapoport <rppt@kernel.org> · 2023-01-26
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Matthew Wilcox <willy@infradead.org> · 2023-01-26
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Suren Baghdasaryan <surenb@google.com> · 2023-01-26
[PATCH v2 2/6] mm: replace VM_LOCKED_CLEAR_MASK with VM_LOCKED_MASK · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 2/6] mm: replace VM_LOCKED_CLEAR_MASK with VM_LOCKED_MASK · Michal Hocko <mhocko@suse.com> · 2023-01-25
Re: [PATCH v2 2/6] mm: replace VM_LOCKED_CLEAR_MASK with VM_LOCKED_MASK · Mike Rapoport <rppt@kernel.org> · 2023-01-26
[PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise · Michal Hocko <mhocko@suse.com> · 2023-01-25
Re: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise · Michal Hocko <mhocko@suse.com> · 2023-01-25
Re: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise · Mike Rapoport <rppt@kernel.org> · 2023-01-26
[PATCH v2 6/6] mm: export dump_mm() · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 6/6] mm: export dump_mm() · Michal Hocko <mhocko@suse.com> · 2023-01-25
Re: [PATCH v2 6/6] mm: export dump_mm() · Mike Rapoport <rppt@kernel.org> · 2023-01-26
[PATCH v2 5/6] mm: introduce mod_vm_flags_nolock and use it in untrack_pfn · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 5/6] mm: introduce mod_vm_flags_nolock and use it in untrack_pfn · Michal Hocko <mhocko@suse.com> · 2023-01-25
Re: [PATCH v2 5/6] mm: introduce mod_vm_flags_nolock and use it in untrack_pfn · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 5/6] mm: introduce mod_vm_flags_nolock and use it in untrack_pfn · Mike Rapoport <rppt@kernel.org> · 2023-01-26

From: Matthew Wilcox <willy@infradead.org>
Date: 2023-01-26 15:11:34
Also in: alsa-devel, amd-gfx, bpf, dmaengine, dri-devel, intel-gfx, kexec, kvm, linux-acpi, linux-arch, linux-arm-msm, linux-crypto, linux-ext4, linux-fbdev, linux-fsdevel, linux-media, linux-mediatek, linux-mm, linux-perf-users, linux-rdma, linux-s390, linux-samsung-soc, linux-scsi, linux-staging, linux-tegra, linux-um, linux-usb, linux-xfs, lkml, loongarch, netdev, nvdimm, selinux, sparclinux, target-devel, virtualization, xen-devel

On Thu, Jan 26, 2023 at 04:50:59PM +0200, Mike Rapoport wrote:

On Thu, Jan 26, 2023 at 11:17:09AM +0200, Mike Rapoport wrote:

quoted

On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote:

quoted

+/* Use when VMA is not part of the VMA tree and needs no locking */
+static inline void init_vm_flags(struct vm_area_struct *vma,
+				 unsigned long flags)

I'd suggest to make it vm_flags_init() etc.

Thinking more about it, it will be even clearer to name these vma_flags_xyz()

Perhaps vma_VERB_flags()?

vma_init_flags()
vma_reset_flags()
vma_set_flags()
vma_clear_flags()
vma_mod_flags()

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help