Re: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise

[PATCH v2 0/6] introduce vm_flags modifier functions · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
[PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls · Michal Hocko <mhocko@suse.com> · 2023-01-25
Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls · Mike Rapoport <rppt@kernel.org> · 2023-01-26
Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls · Sebastian Reichel <hidden> · 2023-01-26
[PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Michal Hocko <mhocko@suse.com> · 2023-01-25
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Peter Zijlstra <peterz@infradead.org> · 2023-01-25
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Matthew Wilcox <willy@infradead.org> · 2023-01-25
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Matthew Wilcox <willy@infradead.org> · 2023-01-25
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Mike Rapoport <rppt@kernel.org> · 2023-01-26
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Mike Rapoport <rppt@kernel.org> · 2023-01-26
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Matthew Wilcox <willy@infradead.org> · 2023-01-26
Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions · Suren Baghdasaryan <surenb@google.com> · 2023-01-26
[PATCH v2 2/6] mm: replace VM_LOCKED_CLEAR_MASK with VM_LOCKED_MASK · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 2/6] mm: replace VM_LOCKED_CLEAR_MASK with VM_LOCKED_MASK · Michal Hocko <mhocko@suse.com> · 2023-01-25
Re: [PATCH v2 2/6] mm: replace VM_LOCKED_CLEAR_MASK with VM_LOCKED_MASK · Mike Rapoport <rppt@kernel.org> · 2023-01-26
[PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise · Michal Hocko <mhocko@suse.com> · 2023-01-25
Re: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise · Michal Hocko <mhocko@suse.com> · 2023-01-25
Re: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise · Mike Rapoport <rppt@kernel.org> · 2023-01-26
[PATCH v2 6/6] mm: export dump_mm() · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 6/6] mm: export dump_mm() · Michal Hocko <mhocko@suse.com> · 2023-01-25
Re: [PATCH v2 6/6] mm: export dump_mm() · Mike Rapoport <rppt@kernel.org> · 2023-01-26
[PATCH v2 5/6] mm: introduce mod_vm_flags_nolock and use it in untrack_pfn · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 5/6] mm: introduce mod_vm_flags_nolock and use it in untrack_pfn · Michal Hocko <mhocko@suse.com> · 2023-01-25
Re: [PATCH v2 5/6] mm: introduce mod_vm_flags_nolock and use it in untrack_pfn · Suren Baghdasaryan <surenb@google.com> · 2023-01-25
Re: [PATCH v2 5/6] mm: introduce mod_vm_flags_nolock and use it in untrack_pfn · Mike Rapoport <rppt@kernel.org> · 2023-01-26

From: Michal Hocko <mhocko@suse.com>
Date: 2023-01-25 09:39:00
Also in: alsa-devel, amd-gfx, bpf, dmaengine, dri-devel, intel-gfx, kexec, kvm, linux-acpi, linux-arch, linux-arm-msm, linux-crypto, linux-ext4, linux-fbdev, linux-fsdevel, linux-media, linux-mediatek, linux-mm, linux-perf-users, linux-rdma, linux-s390, linux-samsung-soc, linux-scsi, linux-staging, linux-tegra, linux-um, linux-usb, linux-xfs, lkml, loongarch, netdev, nvdimm, selinux, sparclinux, target-devel, xen-devel

On Wed 25-01-23 00:38:49, Suren Baghdasaryan wrote:

Replace indirect modifications to vma->vm_flags with calls to modifier
functions to be able to track flag changes and to keep vma locking
correctness. Add a BUG_ON check in ksm_madvise() to catch indirect
vm_flags modification attempts.

Those BUG_ONs scream to much IMHO. KSM is an MM internal code so I
gueess we should be willing to trust it.

Signed-off-by: Suren Baghdasaryan <surenb@google.com>

Acked-by: Michal Hocko <mhocko@suse.com>
-- 
Michal Hocko
SUSE Labs

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help