Thread (52 messages) 52 messages, 11 authors, 2023-03-19

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

From: Stephen Kitt <hidden>
Date: 2023-01-09 21:37:39
Also in: dri-devel, linux-arm-kernel, linux-fbdev, linux-omap, linux-staging, lkml

On Sun, 8 Jan 2023 18:26:12 +0100, Helge Deller [off-list ref] wrote:
On 1/7/23 21:53, Sam Ravnborg wrote:
quoted
Hi Stephen.

On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote:  
quoted
On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint
[off-list ref] wrote:  
quoted
From: Sam Ravnborg <redacted>

The atmel_lcdfb had code to save/restore power state.
This is not needed so drop it.

Introduce backlight_is_brightness() to make logic simpler.

Signed-off-by: Sam Ravnborg <redacted>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: linux-fbdev@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
drivers/video/fbdev/atmel_lcdfb.c | 24 +++---------------------
1 file changed, 3 insertions(+), 21 deletions(-)  
...  
quoted
Hi Sam,

I’d submitted quite a few more of these previously (and you’d reviewed
them), see e.g. the thread starting at
https://lkml.org/lkml/2022/6/7/4365, and yesterday,
https://lkml.org/lkml/2023/1/6/520, https://lkml.org/lkml/2023/1/6/656,
https://lkml.org/lkml/2023/1/6/970, https://lkml.org/lkml/2023/1/6/643,
and https://lkml.org/lkml/2023/1/6/680. There are a few more, I can find
them if it’s any use.  
The patches from yesterday was what triggered me to resurrect an old
branch of mine where I had done something similar. I had lost all
memory of reviewing similar patches from you.


Helge - could you pick the reviewed patches from:
https://lore.kernel.org/all/20220607192335.1137249-1-steve@sk2.org/ (local)
[This is the same mail as Stephen refer to above - looked up via lore].  
I just pulled those 7 patches into fbdev/for-next.
If you need more, please let me know,
Please pull
https://lore.kernel.org/lkml/20230109200239.1850611-1-steve@sk2.org/ (local) too, it
completes the fbdev set. (It’s a re-send of
https://lore.kernel.org/lkml/20220609180440.3138625-1-steve@sk2.org/ (local)).

Thanks,

Stephen

Attachments

  • (unnamed) [application/pgp-signature] 833 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help