Re: [PATCH 09/15] staging: fbtft: fb_ssd1351.c: Introduce backlight_is_blank()

From
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date
2023-01-09 11:13:26
Also in
dri-devel, linux-arm-kernel, linux-fbdev, linux-omap, linux-staging, lkml
Reply to
Sam Ravnborg via B4 Submission Endpoint, 2023-01-07
On Sat, Jan 07, 2023 at 07:26:23PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote:
From: Sam Ravnborg <redacted>

Avoiding direct access to backlight_properties.props.

Access to the deprecated props.fb_blank replaced by backlight_is_blank().
Access to props.power is dropped - it was only used for debug.
Signed-off-by: Sam Ravnborg <redacted>
Cc: Stephen Kitt <redacted>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Daniel Thompson <redacted>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: <redacted>
Not sure why you have this (at least) explicitly mentioned as get_maintainer.pl
can generate it and git send-email can utilize the script output...

...
-	write_reg(par, 0xB5, on ? 0x03 : 0x02);
+	write_reg(par, 0xB5, !blank ? 0x03 : 0x02);
Why not positive conditional?

	write_reg(par, 0xB5, blank ? 0x02 : 0x03);

-- 
With Best Regards,
Andy Shevchenko

Thread (52 messages) 52 messages, 11 authors, last reply 2023-03-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help