On 8 January 2023 08:45:46 CET, Stephen Kitt [off-list ref] wrote:
On 7 January 2023 21:53:46 CET, Sam Ravnborg [off-list ref] wrote:
quoted
Hi Stephen.
On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote:
quoted
On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint [off-list ref] wrote:
quoted
From: Sam Ravnborg <redacted>
The atmel_lcdfb had code to save/restore power state.
This is not needed so drop it.
Introduce backlight_is_brightness() to make logic simpler.
Signed-off-by: Sam Ravnborg <redacted>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: <redacted>
Cc: <redacted>
---
drivers/video/fbdev/atmel_lcdfb.c | 24 +++---------------------
1 file changed, 3 insertions(+), 21 deletions(-)
...
quoted
Hi Sam,
I’d submitted quite a few more of these previously (and you’d reviewed them), see e.g. the thread starting at https://lkml.org/lkml/2022/6/7/4365, and yesterday, https://lkml.org/lkml/2023/1/6/520, https://lkml.org/lkml/2023/1/6/656, https://lkml.org/lkml/2023/1/6/970, https://lkml.org/lkml/2023/1/6/643, and https://lkml.org/lkml/2023/1/6/680. There are a few more, I can find them if it’s any use.
The patches from yesterday was what triggered me to resurrect an old
branch of mine where I had done something similar. I had lost all
memory of reviewing similar patches from you.
Helge - could you pick the reviewed patches from:
https://lore.kernel.org/all/20220607192335.1137249-1-steve@sk2.org/ (local)
[This is the same mail as Stephen refer to above - looked up via lore].
Stephen - I expect Daniel/Lee to take care of the patches from yesterday.
If you can look up other pending patches from you please do so, so we
can have them applied.
Preferably with links to lore - as this makes it easier to apply them.
Review of what is unique in this set would be appreciated.
Sam
Hi Sam,
Here are my pending patches from last June on lore:
* https://lore.kernel.org/lkml/20220607190925.1134737-1-steve@sk2.org/ (local)
* https://lore.kernel.org/lkml/20220608205623.2106113-1-steve@sk2.org/ (local)
* https://lore.kernel.org/lkml/20220607192335.1137249-1-steve@sk2.org/ (local)
* https://lore.kernel.org/lkml/20220616170425.1346081-1-steve@sk2.org/ (local)
I’ll send reviews of your other patches later today or tomorrow.
Regards,
Stephen
And the auxdisplay patch, v1:
https://lore.kernel.org/lkml/20220607180406.1116277-1-steve@sk2.org/ (local)
and v2:
https://lore.kernel.org/lkml/20230106143002.1434266-1-steve@sk2.org/ (local)
Regards,
Stephen