Re: [PATCH 10/13] powerpc/rtas: improve function information lookups
From: Nick Child <nnac123@linux.ibm.com>
Date: 2022-11-23 19:33:41
On 11/22/22 20:51, Andrew Donnellan wrote:
On Fri, 2022-11-18 at 09:07 -0600, Nathan Lynch wrote:quoted
+enum rtas_function_flags { + RTAS_FN_FLAG_BANNED_FOR_SYSCALL_ON_LE = (1 << 0), +};This seems to be new, what's the justification?
Seems to be a run-time replacement of:
#ifdef CONFIG_CPU_BIG_ENDIAN
{ "ibm,suspend-me", -1, -1, -1, -1, -1 },
{ "ibm,update-nodes", -1, 0, -1, -1, -1, 4096 },
{ "ibm,update-properties", -1, 0, -1, -1, -1, 4096 },
#endif
It looks to be handled logically:
+ if (IS_ENABLED(CONFIG_CPU_LITTLE_ENDIAN) &&
+ (func->flags & RTAS_FN_FLAG_BANNED_FOR_SYSCALL_ON_LE))
+ goto err;
Perhaps, also allow the addition of any future special cases
for rtas functions easier to maintain?