Re: [PATCH 10/13] powerpc/rtas: improve function information lookups

From
Andrew Donnellan <hidden>
Date
2022-11-23 02:52:23
Reply to
Nathan Lynch, 2022-11-18
On Fri, 2022-11-18 at 09:07 -0600, Nathan Lynch wrote:
Convert rtas_token() to use a lockless binary search on the function
table. Fall back to the old behavior for lookups against names that
are not known to be RTAS functions, but issue a warning. rtas_token()
is for function names; it is not a general facility for accessing
arbitrary properties of the /rtas node. All known misuses of
rtas_token() have been converted to more appropriate of_ APIs in
preceding changes.
For in-kernel users, why not go all the way: make rtas_token() static
and use it purely for the userspace API, and switch kernel users over
to using rtas_function_index directly?
quoted hunk ↗ jump to hunk
+enum rtas_function_flags {
+       RTAS_FN_FLAG_BANNED_FOR_SYSCALL_ON_LE = (1 << 0),
+};
This seems to be new, what's the justification?

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@linux.ibm.com   IBM Australia Limited
Thread (49 messages) 49 messages, 6 authors, last reply 2022-12-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help