Re: [RFC PATCH 1/6] testing/pkeys: Add command line options

On 6/10/2022 4:35 PM, ira.weiny@intel.com wrote:

Add command line options for debug level and number of iterations.

$ ./protection_keys_64 -h
Usage: ./protection_keys_64 [-h,-d,-i <iter>]
         --help,-h   This help
	--debug,-d  Increase debug level for each -d

Is this mechanism (of counting d's) commonplace in other selftests as 
well? Looking at the test code for pkeys the debug levels run from 1-5. 
That feels like quite a few d's to input :)

Would it be easier to input the number in the command line directly?

Either way it would be useful to know the debug range in the help.
Maybe something like:
	--debug,-d  Increase debug level for each -d (1-5)

The patch seems fine to me otherwise.

	--iterations,-i <iter>  repeate test <iter> times
		default: 22

Thanks,
Sohil