Thread (5 messages) 5 messages, 4 authors, 2022-05-24

Re: [PATCH -next] powerpc/book3e: Fix build error

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2022-05-18 04:50:45
Also in: lkml

YueHaibing [off-list ref] writes:
On 2022/5/17 18:45, Christophe Leroy wrote:
quoted
Le 17/05/2022 à 11:48, YueHaibing a écrit :
quoted
arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
   early_get_first_memblock_info(__va(dt_ptr), &size);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Add missing include file linux/of_fdt.h to fix this.

Signed-off-by: YueHaibing <redacted>
Thats for fixing that.

Reviewed-by: Christophe Leroy <redacted>

It means we don't have any defconfig for 32 bits booke with 
CONFIG_RELOCATABLE ?
Indeed, there is no defconfig with CONFIG_RELOCATABLE under arch/powerpc/configs
It's selected by CRASH_DUMP, which is in ppc64_defconfig.

But it's not enabled in corenet32_smp_defconfig which is what I build,
or any of the other 85xx configs.

I guess it should be, I think it's true that RELOCATABLE=y exercises
more interesting code paths?

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help