Re: [PATCH -next] powerpc/book3e: Fix build error

From
YueHaibing <hidden>
Date
2022-05-17 11:32:01
Also in
lkml
Reply to
Christophe Leroy, 2022-05-17
On 2022/5/17 18:45, Christophe Leroy wrote:

Le 17/05/2022 à 11:48, YueHaibing a écrit :
quoted
arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
   early_get_first_memblock_info(__va(dt_ptr), &size);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Add missing include file linux/of_fdt.h to fix this.

Signed-off-by: YueHaibing <redacted>
Thats for fixing that.

Reviewed-by: Christophe Leroy <redacted>

It means we don't have any defconfig for 32 bits booke with 
CONFIG_RELOCATABLE ?
Indeed, there is no defconfig with CONFIG_RELOCATABLE under arch/powerpc/configs
quoted
---
  arch/powerpc/mm/nohash/fsl_book3e.c | 1 +
  1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/mm/nohash/fsl_book3e.c b/arch/powerpc/mm/nohash/fsl_book3e.c
index 08a984e29433..093da4dbdee1 100644
--- a/arch/powerpc/mm/nohash/fsl_book3e.c
+++ b/arch/powerpc/mm/nohash/fsl_book3e.c
@@ -36,6 +36,7 @@
  #include <linux/delay.h>
  #include <linux/highmem.h>
  #include <linux/memblock.h>
+#include <linux/of_fdt.h>
  
  #include <asm/io.h>
  #include <asm/mmu_context.h>
Thread (5 messages) 5 messages, 4 authors, last reply 2022-05-24
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help