[PATCH -next] powerpc/book3e: Fix build error

arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
  early_get_first_memblock_info(__va(dt_ptr), &size);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Add missing include file linux/of_fdt.h to fix this.

Signed-off-by: YueHaibing <redacted>
---
 arch/powerpc/mm/nohash/fsl_book3e.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/mm/nohash/fsl_book3e.c b/arch/powerpc/mm/nohash/fsl_book3e.c
index 08a984e29433..093da4dbdee1 100644
--- a/arch/powerpc/mm/nohash/fsl_book3e.c
+++ b/arch/powerpc/mm/nohash/fsl_book3e.c

@@ -36,6 +36,7 @@
 #include <linux/delay.h>
 #include <linux/highmem.h>
 #include <linux/memblock.h>
+#include <linux/of_fdt.h>
 
 #include <asm/io.h>
 #include <asm/mmu_context.h>

-- 
2.17.1

Le 17/05/2022 à 11:48, YueHaibing a écrit :

arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
   early_get_first_memblock_info(__va(dt_ptr), &size);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Add missing include file linux/of_fdt.h to fix this.

Signed-off-by: YueHaibing <redacted>

Thats for fixing that.

Reviewed-by: Christophe Leroy <redacted>

It means we don't have any defconfig for 32 bits booke with 
CONFIG_RELOCATABLE ?

On 2022/5/17 18:45, Christophe Leroy wrote:

Le 17/05/2022 à 11:48, YueHaibing a écrit :

quoted

arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
   early_get_first_memblock_info(__va(dt_ptr), &size);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Add missing include file linux/of_fdt.h to fix this.

Signed-off-by: YueHaibing <redacted>

Thats for fixing that.

Reviewed-by: Christophe Leroy <redacted>

It means we don't have any defconfig for 32 bits booke with 
CONFIG_RELOCATABLE ?

Indeed, there is no defconfig with CONFIG_RELOCATABLE under arch/powerpc/configs

quoted

---
  arch/powerpc/mm/nohash/fsl_book3e.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/mm/nohash/fsl_book3e.c b/arch/powerpc/mm/nohash/fsl_book3e.c
index 08a984e29433..093da4dbdee1 100644
--- a/arch/powerpc/mm/nohash/fsl_book3e.c
+++ b/arch/powerpc/mm/nohash/fsl_book3e.c

@@ -36,6 +36,7 @@
  #include <linux/delay.h>
  #include <linux/highmem.h>
  #include <linux/memblock.h>
+#include <linux/of_fdt.h>
  
  #include <asm/io.h>
  #include <asm/mmu_context.h>

YueHaibing [off-list ref] writes:

On 2022/5/17 18:45, Christophe Leroy wrote:

quoted

Le 17/05/2022 à 11:48, YueHaibing a écrit :

quoted

arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
   early_get_first_memblock_info(__va(dt_ptr), &size);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Add missing include file linux/of_fdt.h to fix this.

Signed-off-by: YueHaibing <redacted>

Thats for fixing that.

Reviewed-by: Christophe Leroy <redacted>

It means we don't have any defconfig for 32 bits booke with 
CONFIG_RELOCATABLE ?

Indeed, there is no defconfig with CONFIG_RELOCATABLE under arch/powerpc/configs

It's selected by CRASH_DUMP, which is in ppc64_defconfig.

But it's not enabled in corenet32_smp_defconfig which is what I build,
or any of the other 85xx configs.

I guess it should be, I think it's true that RELOCATABLE=y exercises
more interesting code paths?

cheers

On Tue, 17 May 2022 17:48:30 +0800, YueHaibing wrote:

arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
  early_get_first_memblock_info(__va(dt_ptr), &size);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Add missing include file linux/of_fdt.h to fix this.

[...]

Applied to powerpc/next.

[1/1] powerpc/book3e: Fix build error
      https://git.kernel.org/powerpc/c/7574dd080ee0a1e8a9c6312dc7c8fe97f73415ff

cheers